Split out an "ndc-models" crate which provides the models. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that applications that do not need the client will not bring in unnecessary dependencies such as `reqwest` (and the whole HTTP stack).
paf31
reviewed
Mar 26, 2024
There was a problem hiding this comment.
The name "models" came from the original OpenAPI generator code, and I've been meaning to change it for a long time. Maybe now is the time. Models is a fine name, and I don't really have a better one (spec, types maybe) but it's worth thinking about now.
This will also break the book generation, FYI, so those references to models.rs will need to be updated.
|
I've fixed the book. Thanks for pointing it out. If you can come up with a better name, I am all ears. Nothing is jumping out at me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that applications that do not need the client will not bring in unnecessary dependencies such as
reqwest(and the whole HTTP stack).