Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notification formatting #17

Merged
merged 2 commits into from
Sep 15, 2020

Conversation

sparr
Copy link
Contributor

@sparr sparr commented Sep 14, 2020

Two changes here. First, the % in the notification is padded to three characters with spaces, so that the progress bar doesn't move around at 0 vs ## vs 100%. Second, reimplemented the progress bar to fix a bug where 0% displayed with two characters instead of zero, getting rid of an eval in the process.

@hastinbe hastinbe self-assigned this Sep 15, 2020
@hastinbe hastinbe merged commit 8bea821 into hastinbe:master Sep 15, 2020
@hastinbe
Copy link
Owner

Thanks, I like the bash-only alternative

@sparr
Copy link
Contributor Author

sparr commented Sep 15, 2020

I thought you might, right after I'd already committed the version with sed, so I went back to fix it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants