Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump for brick windows #912

Merged
merged 9 commits into from
Nov 10, 2023
Merged

Bump for brick windows #912

merged 9 commits into from
Nov 10, 2023

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Nov 5, 2023

ghcup_windows_brick

@hasufell hasufell mentioned this pull request Nov 5, 2023
@jtdaugherty
Copy link

Just a word of caution: we discovered some issues in vty-windows that got fixed and some that are still being investigated. Please make sure you test well and use the latest vty-windows release!

@hasufell
Copy link
Member Author

hasufell commented Nov 5, 2023

and some that are still being investigated

Can you let us know what this is?

@hasufell
Copy link
Member Author

hasufell commented Nov 5, 2023

I noticed that I can't do anything during suspendAndResume. It seems all input is ignored. Or at least sometimes... maybe when I press ctrl+c?

@jtdaugherty
Copy link

@hasufell I was thinking of the discussion at chhackett/vty-windows#10 - although those have largely been fixed at this point.

Is the suspendAndResume misbehavior happening on Windows?

@chhackett
Copy link

and some that are still being investigated

Can you let us know what this is?

@hasufell
Hello,
I uploaded a patch today that fixes the remaining weird artifact issues in Powershell and cmd windows.

There is still one issue with colors getting rendered incorrectly in Powershell only.
chhackett/vty-windows#13

@hasufell
Copy link
Member Author

hasufell commented Nov 6, 2023

Is the suspendAndResume misbehavior happening on Windows?

Yeah, but I think it's fixed now.

@jtdaugherty
Copy link

Yeah, but I think it's fixed now.

That doesn't sound good. (As in, perhaps it doesn't work some of the time due to a race or something.) There could be something amiss in the Windows shutdown/startup code that needs to be adjusted..

@hasufell
Copy link
Member Author

hasufell commented Nov 9, 2023

Yeah, but I think it's fixed now.

That doesn't sound good. (As in, perhaps it doesn't work some of the time due to a race or something.) There could be something amiss in the Windows shutdown/startup code that needs to be adjusted..

I think the only way is to put it out there. I can't reproduce properly.

@hasufell hasufell merged commit a7be1e7 into master Nov 10, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants