Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twitter user sees channel specific twitter card #191

Merged
merged 5 commits into from
Nov 5, 2017
Merged

Twitter user sees channel specific twitter card #191

merged 5 commits into from
Nov 5, 2017

Commits on Nov 5, 2017

  1. Channel specific twittercards

    @jwworth
    Chris Erin and Vidal Ekechukwu authored and jwworth committed Nov 5, 2017
    Configuration menu
    Copy the full SHA
    22e16c5 View commit details
    Browse the repository at this point in the history

  2. Twitter user sees channel specific twitter card

    @chriserin @jwworth
    chriserin authored and jwworth committed Nov 5, 2017
    Configuration menu
    Copy the full SHA
    b6a8d84 View commit details
    Browse the repository at this point in the history

  3. Check for loaded channel association

    @chriserin @jwworth
    chriserin authored and jwworth committed Nov 5, 2017
    Configuration menu
    Copy the full SHA
    2824d30 View commit details
    Browse the repository at this point in the history

  4. Move twitter image & description logic to View

    @chriserin @jwworth
    chriserin authored and jwworth committed Nov 5, 2017
    Configuration menu
    Copy the full SHA
    185b548 View commit details
    Browse the repository at this point in the history

  5. Use case insensitivity on text comparison in tests 

    I was having a problem on my machine only with comparing
all caps words in the browser with the expected text.

The browser upcases words with css, using the value post
css may not be available in some setups (like mine)
    @chriserin @jwworth
    chriserin authored and jwworth committed Nov 5, 2017
    Configuration menu
    Copy the full SHA
    da89b91 View commit details
    Browse the repository at this point in the history