updated usage example #9081
Merged
updated usage example #9081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
IMO - request is reasonable - as opposed to using here strings ( |
mladlow
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
On the one hand, I feel like this is very subjective. On the other hand I personally find here strings very confusing and would prefer the new syntax. @devops-rob I think you might need to update this PR from main before it can be merged.
…ead that's more simple.
taoism4504
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the code in the docs for the transit secrets engine example because it assumes that the user is using a bash shell where the <<< redirect will work. I went through the example using the docker image that we publish and that doesn't use a bash shell so it didn't work.
I think using echo and piping into base64 command is much more universal and will work across all of the shells