Fix for using ExplicitMaxTTL in auth method plugins. #5379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove the .pb.go files from the PR. You appear to be using a different version of protobuf and/or go-protobuf and it makes it harder to see the actual changes, plus these are generated automatically anyways so any changes in this PR will simply be overwritten. |
|
@jefferai Thanks for your prompt reply. I have removed the generated |
briankassouf
approved these changes
Sep 21, 2018
|
Thanks! |
joelthompson
added a commit
to joelthompson/vault
that referenced
this pull request
Sep 22, 2018
In hashicorp#5379, changes were made to the .proto files but the generated .pb.go files weren't included. This causes compilation errors because .pb.go weren't always being regenerated (e.g., with make dev and in travis). This includes necessary changes to .pb.go to fix these errors.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We like to use periodic tokens with explicit max TTL in one of our auth method plugins. The field logical.Auth.ExplicitMaxTTL was not serialized over proto bufs and in the token storage.
This PR fixes the serialization of ExplicitMaxTTL and enables to limit periodic tokens by setting the explicit max TTL in our plugins.