Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enterprise tests failing after Web REPL a11y updates #27092

Merged
merged 2 commits into from
May 16, 2024
Merged

Fix enterprise tests failing after Web REPL a11y updates #27092

merged 2 commits into from
May 16, 2024

Conversation

hashishaw
Copy link
Contributor

This PR updates a couple test failures after #26872 was merged. I also attempted to stabilize the KMIP flaky tests in this

  • Ent tests pass

@hashishaw hashishaw added this to the 1.17.0-rc milestone May 16, 2024
@hashishaw hashishaw requested a review from a team as a code owner May 16, 2024 19:10
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited
Loading

Build Results:
All builds succeeded! ✅

Monkeychip
Monkeychip approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for picking these up!

@hashishaw hashishaw merged commit 2278c8c into main May 16, 2024
31 checks passed
@hashishaw hashishaw deleted the ui/fix-ent-tests-after-repl-a11y branch May 16, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Milestone
1.17.0-rc
Development

Successfully merging this pull request may close these issues.
2 participants
@hashishaw @Monkeychip