Bug fix: Update KV data when you change the version of a nested secret #25152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
hellobontempo
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
These look good to me. In the PR description it might be worth including this resolves a regression introduced by #24224 which is why we're backporting to 1.15
revert accidental next step
2 tasks
Monkeychip
added a commit
that referenced
this pull request
Feb 5, 2024
#25152) * wip need to address testing but want to test something quick on 1.13 * add test coverage * changelog * update test comment * rename getter * Update kv-data-fields.hbs revert accidental next step * linting things
Monkeychip
added a commit
that referenced
this pull request
Feb 7, 2024
#25152) * wip need to address testing but want to test something quick on 1.13 * add test coverage * changelog * update test comment * rename getter * Update kv-data-fields.hbs revert accidental next step * linting things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25029.
Regression caused by #24224
This was caused because we were using a tracked property (
this.codeMirrorSring) for the secret data and we needed a getter that relied on thethis.args.secretmodel arg. The secret model was updating and thus thesecretDatawas correct behind the scenes but the tracked property was not re-firing because it didn't rely on anything that was triggering a re-fire of the property.