UI: Display minus icon for empty MaskedInput value. Show MaskedInput for KV secrets without values #22039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
<MaskedInput>
component shows when it has no value<Icon @name="minus" />
) so that it is more clear to users that there is simply no value there<MaskedInput>
. This makes it so that the KV secrets page looks more consistent even if there are keys with no valuesPictures:
![Before](https://private-user-images.githubusercontent.com/104539507/255747308-84bc6bc5-8958-4bea-8130-0ce8c6766ccb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzMDUzMjIsIm5iZiI6MTcyMTMwNTAyMiwicGF0aCI6Ii8xMDQ1Mzk1MDcvMjU1NzQ3MzA4LTg0YmM2YmM1LTg5NTgtNGJlYS04MTMwLTBjZThjNjc2NmNjYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxOFQxMjE3MDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hMWU5NTFkNDdlZjUyZDJmMDJkZTQ1NmNiMWY0ODQzNmZmN2FmMmU3OTE0MzM5MTQ5YzY3YWRjYzViNjBjZThjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9._ovk-yhUKB_zi_vEAbDW5qC5PaXNdS0DXmZPewgdcCU)
Before:
After:
![After 1](https://private-user-images.githubusercontent.com/104539507/255747322-6c8594f0-1a18-4bdb-b4e8-11735eea7b72.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzMDUzMjIsIm5iZiI6MTcyMTMwNTAyMiwicGF0aCI6Ii8xMDQ1Mzk1MDcvMjU1NzQ3MzIyLTZjODU5NGYwLTFhMTgtNGJkYi1iNGU4LTExNzM1ZWVhN2I3Mi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxOFQxMjE3MDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01NDI4Mjk2YThlN2MzMjgyYTk4YjExNDk1ZTM2ZmRmMzk3YTY5Yzc3MmNiMDYxYTkyNGVmMmNjZTIyZDYxMzhmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.UF6i8BQhwEsYm5sNZLA2Iy-2-2pULYFpz-LWqqtn1r0)
![After 2](https://private-user-images.githubusercontent.com/104539507/255747332-80dba43f-cd84-47ea-b5fd-f618b82dc55e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzMDUzMjIsIm5iZiI6MTcyMTMwNTAyMiwicGF0aCI6Ii8xMDQ1Mzk1MDcvMjU1NzQ3MzMyLTgwZGJhNDNmLWNkODQtNDdlYS1iNWZkLWY2MThiODJkYzU1ZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxOFQxMjE3MDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xMTdhNTViNDk5NjhhMzFjYjJiYWQzOTNlODkxZGQ2ZmY0MTdlZWVhMWVkYjY1YWRhZmJjNThkNjhiNzM3NjNiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.7YvJpP6iAOBZ6alxfbatCvUAW8uNvqBrhr6xLt1CTz0)