Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of openapi: Fix logic for labeling unauthenticated/sudo paths into release/1.11.x #19634

Merged

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19600 to be assessed for backporting due to the inclusion of the label backport/1.11.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


The previous logic for matching unauthenticated & sudo paths in OpenAPI did not take into account the + wildcard, so some of the PKI paths were skipped.

With new logic, these are the new unauthenticated paths introduced for builtin plugins:

❱ diff unauth_before unauth_after2
27a28,30
> "/identity/oidc/provider/{name}/.well-known/keys"
> "/identity/oidc/provider/{name}/.well-known/openid-configuration"
> "/identity/oidc/provider/{name}/token"
57a61,69
> "/{pki_mount_path}/issuer/{issuer_ref}/crl"
> "/{pki_mount_path}/issuer/{issuer_ref}/crl/delta"
> "/{pki_mount_path}/issuer/{issuer_ref}/crl/delta/der"
> "/{pki_mount_path}/issuer/{issuer_ref}/crl/delta/pem"
> "/{pki_mount_path}/issuer/{issuer_ref}/crl/der"
> "/{pki_mount_path}/issuer/{issuer_ref}/crl/pem"
> "/{pki_mount_path}/issuer/{issuer_ref}/der"
> "/{pki_mount_path}/issuer/{issuer_ref}/json"
> "/{pki_mount_path}/issuer/{issuer_ref}/pem"

The list of "sudo" paths is unaffected by this PR for builtin plugins.

Resolves: #19581, VAULT-14576


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/special-paths-fix/hopelessly-possible-bedbug branch 2 times, most recently from accc9be to 96bcc7c Compare March 20, 2023 17:26
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 20, 2023

CLA assistant check
All committers have signed the CLA.

@averche averche marked this pull request as ready for review March 20, 2023 20:42
@averche averche enabled auto-merge (squash) March 20, 2023 20:43
@averche averche force-pushed the backport/special-paths-fix/hopelessly-possible-bedbug branch from ce958bd to 5ec90dc Compare March 21, 2023 20:07
@averche averche merged commit 87b77ff into release/1.11.x Mar 21, 2023
@averche averche deleted the backport/special-paths-fix/hopelessly-possible-bedbug branch March 21, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants