Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade vault-plugin-secrets-gcpkms to v0.13.0 #17199

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Sep 19, 2022

No description provided.

Copy link
Member

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could add changelog similar to https://github.com/hashicorp/vault/pull/17174/files (but omit the go-gcp-common dep).

Something like:

```release-note:improvement
secrets/gcpkms: Updates dependency google.golang.org/[email protected].
```

@benashz benashz force-pushed the update-plugin-vault-plugin-secrets-gcpkms-v0.13.0 branch from e7bf248 to 8632272 Compare September 19, 2022 16:40
@benashz benashz merged commit bc1e2e6 into main Sep 19, 2022
@benashz benashz deleted the update-plugin-vault-plugin-secrets-gcpkms-v0.13.0 branch September 19, 2022 16:57
@@ -0,0 +1,3 @@
```release-note:improvement
secrets/gcp: Update `github.com/hashicorp/vault-plugin-secrets-gcpkms` to `v0.13.0`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh shoot, I meant to suggest a CL update for what actually changed in the plugin itself instead of this version bump in Vault. The change in the plugin itself is that we updated its google.golang.org/api dependency to v0.83.0. I think the CL entry that I placed in my other comment is the one we need.

Exactly like this:

```release-note:improvement
secrets/gcpkms: Updates `google.golang.org/api` dependency to `v0.83.0`.
```

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #17202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants