Backport of identity/oidc: fixes validation of the request and request_uri parameters into release/1.11.x #16617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
requested a review
from taoism4504
as a code owner
hc-github-team-secure-vault-core
force-pushed
the
backport/oidc-request-params/loosely-wired-anemone
branch
from
d646bf6
to
4f72583
Compare
austingebauer
approved these changes
Aug 5, 2022
austingebauer
deleted the
backport/oidc-request-params/loosely-wired-anemone
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16600 to be assessed for backporting due to the inclusion of the label backport/1.11.x.
The below text is copied from the body of the original PR.
This PR fixes required validation already present in identity_store_oidc_provider.go#L1684-L1693 which wasn't being passed to the server by UI code. It also adds the
request_parameter_supportedfield to the OIDC discovery document per 6.1. Passing a Request Object by Value.Overview of commits