Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent/template: fix exec parsing error for templates #16231

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

jasonodonnell
Copy link
Contributor

@jasonodonnell jasonodonnell commented Jul 6, 2022

When attempting to parse exec in template stanzas, the map was being decoded as a slice, but exec expects a map:

Error loading configuration from $FILE.json: error parsing 'template': 1 error(s) decoding:

* 'exec' expected a map, got 'slice'

This is similar to wait and needs to be treated appropriately by flattening the slice.

Fixes #16230.

@jasonodonnell jasonodonnell requested a review from a team July 6, 2022 20:02
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonodonnell jasonodonnell enabled auto-merge (squash) July 6, 2022 20:16
@jasonodonnell jasonodonnell merged commit 8a49422 into main Jul 6, 2022
@jasonodonnell jasonodonnell deleted the template-exec-slice-err branch July 6, 2022 20:41
jasonodonnell added a commit that referenced this pull request Jul 6, 2022
* agent/template: fix exec parsing error for templates

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vault template stanza exec object appears to not parse correctly
3 participants