remove storybook: #15074
Merged
remove storybook: #15074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zofskeez
approved these changes
Apr 19, 2022
kitography
pushed a commit
that referenced
this pull request
Apr 24, 2022
* remove storybook: * changelog * clean up * update browserstack * remove special case for storybook * add back gen-story-md
schultz-is
pushed a commit
that referenced
this pull request
Apr 27, 2022
* remove storybook: * changelog * clean up * update browserstack * remove special case for storybook * add back gen-story-md
schultz-is
pushed a commit
that referenced
this pull request
May 2, 2022
* remove storybook: * changelog * clean up * update browserstack * remove special case for storybook * add back gen-story-md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a team we decided to remove storybook. We didn't use it often enough and it was becoming a burden to update it's dependencies.
Here was the original PR that added storybook.
I also updated browserstack. Not entirely sure why, but after removing the storybook dependencies from the package.json file, browserstack started to fail. I updated it and it fixed it. I wish I knew the answer to these things, but sometimes the web is too thick.