Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: fix blank selection on search select field #15058

Merged
merged 4 commits into from
Apr 15, 2022
Merged

UI: fix blank selection on search select field #15058

merged 4 commits into from
Apr 15, 2022

Conversation

hashishaw
Copy link
Collaborator

Fixes a bug related to cross-namespace model querying within an entity.

Previous behavior:

  • Search-select component queries against a model in the current namespace
  • The API call returns a 404 because there are no results in the current namespace
  • The item being loaded includes ID's for that model, but they exist in a different namespace
  • BUG: the search-select component shows a blank selection

Before
entity-display-bug
Another workaround for this behavior is to add an item of the type being queried to the current namespace. For example, in the gif above we would create an Entity in the namespace ns1

After
entity-display-fix

@hashishaw hashishaw added ui bug Used to indicate a potential bug backport/1.9.x labels Apr 15, 2022
@hashishaw hashishaw added this to the 1.11.0-rc1 milestone Apr 15, 2022
@vercel vercel bot temporarily deployed to Preview – vault April 15, 2022 15:28 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 15, 2022 15:31 Inactive
Monkeychip
Monkeychip reviewed Apr 15, 2022
View reviewed changes
ui/README.md
@@ -26,6 +26,15 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for updating!

@hashishaw hashishaw merged commit ffe3306 into main Apr 15, 2022
@hashishaw hashishaw deleted the ui/fix-search-select-failed-request branch April 15, 2022 17:47
This was referenced Apr 15, 2022
Closed
Closed
Merged
hashishaw added a commit that referenced this pull request Apr 15, 2022
@hashishaw
UI: fix blank selection on search select field (#15058)
801d156 
* WIP

* Cleanup

* cleanup

* Add changelog
hashishaw added a commit that referenced this pull request Apr 15, 2022
@hashishaw
UI: fix blank selection on search select field (#15058)
d88c0ff 
* WIP

* Cleanup

* cleanup

* Add changelog
This was referenced Apr 15, 2022
Merged
Merged
hashishaw added a commit that referenced this pull request Apr 15, 2022
@hashishaw
UI: fix blank selection on search select field (#15058) (#15065)
2386e66 
* WIP

* Cleanup

* cleanup

* Add changelog
hashishaw added a commit that referenced this pull request Apr 15, 2022
@hashishaw
Backport 1.9.5: UI fix blank selection on search select field (#15058) (
920532a 
#15066)
kitography pushed a commit that referenced this pull request Apr 24, 2022
@hashishaw @kitography
UI: fix blank selection on search select field (#15058)
f5a56e2 
* WIP

* Cleanup

* cleanup

* Add changelog
@thiskevinwang thiskevinwang mentioned this pull request Apr 25, 2022
Closed
schultz-is pushed a commit that referenced this pull request Apr 27, 2022
@hashishaw
UI: fix blank selection on search select field (#15058)
1e89ab2 
* WIP

* Cleanup

* cleanup

* Add changelog
schultz-is pushed a commit that referenced this pull request May 2, 2022
@hashishaw
UI: fix blank selection on search select field (#15058)
0d1b757 
* WIP

* Cleanup

* cleanup

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Milestone
1.11.0-rc1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hashishaw @Monkeychip