Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix barrier key autoration config edge cases #11541

Merged
merged 7 commits into from
May 5, 2021
Merged

Conversation

sgmiller
Copy link
Collaborator

@sgmiller sgmiller commented May 5, 2021

Introduces handling of a TypeInt64 in sdk field data, and uses it in order
to the ability to set values over 2^31 on 32 bit platforms.

Also fixes the ability to set a max_operations without specifying interval
if interval was previously unset.

@vercel vercel bot temporarily deployed to Preview – vault-storybook May 5, 2021 17:20 Inactive
@vercel vercel bot temporarily deployed to Preview – vault May 5, 2021 17:20 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook May 5, 2021 17:25 Inactive
@vercel vercel bot temporarily deployed to Preview – vault May 5, 2021 17:25 Inactive
@sgmiller sgmiller merged commit f538631 into master May 5, 2021
@sgmiller sgmiller deleted the rotate-config-fixes branch May 5, 2021 19:39
@sgmiller sgmiller added this to the 1.7.2 milestone May 5, 2021
AndreyZamyslov pushed a commit to yandex-cloud/vault that referenced this pull request Jun 10, 2021
* Add an Int64 type

* Use the new Int64 type so that even 32 bit builds can specify max_operations above 2^31

* Missed a spot

* go mod vendor

* fix cast

* changelog

* Update unit test to ensure this works on both 32 and 64-bit archs
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
* Add an Int64 type

* Use the new Int64 type so that even 32 bit builds can specify max_operations above 2^31

* Missed a spot

* go mod vendor

* fix cast

* changelog

* Update unit test to ensure this works on both 32 and 64-bit archs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants