Diagnoses Consul Direct Access Check #11505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: swayne275 <[email protected]>
…lt into diagnose-otel-integration
…ration # Conflicts: # command/operator_diagnose.go # command/operator_diagnose_test.go
swayne275
approved these changes
Apr 30, 2021
vault/diagnose/storage_checks.go
Outdated
| // versus directly to a remote server. We can only assume that the local address | ||
| // is a server, not a client. | ||
| func ConsulDirectAccess(config map[string]string) string { | ||
| serviceRegistrationAddr := config["address"] |
There was a problem hiding this comment.
do we want to handle the case where address isn't in config?
vault/diagnose/storage_checks.go
Outdated
| func ConsulDirectAccess(config map[string]string) string { | ||
| serviceRegistrationAddr := config["address"] | ||
| if !strings.Contains(serviceRegistrationAddr, "localhost") && !strings.Contains(serviceRegistrationAddr, "127.0.0.1") { | ||
| return "consul storage does not connect to local agent, but directly to server" |
There was a problem hiding this comment.
does it make sense to const this since we check for it in tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic checks if address is not localhost for any storage or SR configuration stanza. Warnings are moved before errors so they can be relayed even when a particular error occurs.