Introduce Logical Unrecoverable Error, Use it in Expiration Manager #11477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HridoyRoy
suggested changes
Apr 29, 2021
HridoyRoy
reviewed
Apr 29, 2021
|
quotas improvements are included in this ticket: https://hashicorp.atlassian.net/browse/VAULT-2303 |
briankassouf
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one isn't actually that big. It's built on top of #11452, and the
...pb.gofiles can be ignored. Should be able to just look at 01a406b and beyondNote: we'll likely need to run a
make protoand ago mod vendorwhen this auto-merges to ent