Diagnose V0: Storage End to End Checks #11468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgmiller
reviewed
Apr 26, 2021
command/operator_diagnose.go
Outdated
|
|
||
| // Attempt to use storage backend |
There was a problem hiding this comment.
Might break this out into it's own function for tidiness.
Co-authored-by: swayne275 <[email protected]>
…lt into diagnose-otel-integration
…ration # Conflicts: # command/operator_diagnose.go # command/operator_diagnose_test.go
HridoyRoy
changed the title
swayne275
approved these changes
Apr 30, 2021
| "github.com/hashicorp/vault/sdk/physical" | ||
| ) | ||
|
|
||
| const timeoutCallRead string = "lag Read" |
There was a problem hiding this comment.
could you do a const block here?
e.g.
const (
thing1 = "hello"
thing2 = "world"
...
)
There was a problem hiding this comment.
i'm only gonna put one comment for this class of thing, but could you also do the same with other consts and vars? i think it makes it a bit cleaner
vault/diagnose/storage_checks.go
Outdated
| // but I don't think List is ever going to break in isolation. | ||
| func StorageEndToEndLatencyCheck(ctx context.Context, b physical.Backend) error { | ||
|
|
||
| c2 := make(chan string, 1) |
There was a problem hiding this comment.
i don't think this channel needs to be buffered with the current code. you could also do a channel of errors (with nil check instead of success string) which would simplify the code a bit
same with c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR writes, reads, and deletes a secret to physical storage in the root path during the operator diagnose command, with a timeout of 20 seconds. The check aims to diagnose latency issues to storage when vault is down.