Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create helpers which integrate with OpenTelemetry for diagnose collection #11454

Merged
merged 18 commits into from
Apr 29, 2021
Merged

Create helpers which integrate with OpenTelemetry for diagnose collection #11454

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ac1cb11
Create helpers which integrate with OpenTelemetry for diagnose collec…
sgmiller Apr 23, 2021
9ecc19a
Go mod vendor
sgmiller Apr 23, 2021
11224d9
Comments
sgmiller Apr 26, 2021
5a3570e
Update vault/diagnose/helpers.go
sgmiller Apr 26, 2021
112f217
Add unit test/example
sgmiller Apr 26, 2021
e0c3a86
Merge branch 'diagnose-otel-integration' of github.com:/hashicorp/vau…
sgmiller Apr 26, 2021
29be762
tweak output
sgmiller Apr 26, 2021
8d5122d
More comments
sgmiller Apr 26, 2021
b2c1f7f
add spot check concept
sgmiller Apr 26, 2021
76dc535
Get unit tests working on Result structs
sgmiller Apr 28, 2021
bc10247
Fix unit test
sgmiller Apr 28, 2021
f1fea38
Merge remote-tracking branch 'origin/master' into diagnose-otel-integ…
sgmiller Apr 28, 2021
4a6bc9e
Get unit tests working, and make diagnose sessions local rather than …
sgmiller Apr 28, 2021
0682a4f
Comments
sgmiller Apr 28, 2021
14abc7f
Last comments
sgmiller Apr 28, 2021
3286135
No need for init
sgmiller Apr 28, 2021
4d26609
:|
sgmiller Apr 28, 2021
5063844
Fix helpers_test
sgmiller Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Last comments
  • Loading branch information
@sgmiller
sgmiller committed Apr 28, 2021
commit 14abc7f422ec4304cdef612e1dcf1d358beaf48c
6 changes: 6 additions & 0 deletions vault/diagnose/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,20 @@ func Warn(ctx context.Context, msg string) {
span.AddEvent(warningEventName, trace.WithAttributes(messageKey.String(msg)))
}

// SpotOk adds an Ok result without adding a new Span. This should be used for instantaneous checks with no
// possible sub-spans
func SpotOk(ctx context.Context, checkName, message string) {
addSpotCheckResult(ctx, spotCheckOkEventName, checkName, message)
}

// SpotWarn adds a Warning result without adding a new Span. This should be used for instantaneous checks with no
// possible sub-spans
func SpotWarn(ctx context.Context, checkName, message string) {
addSpotCheckResult(ctx, spotCheckWarnEventName, checkName, message)
}

// SpotError adds an Error result without adding a new Span. This should be used for instantaneous checks with no
// possible sub-spans
func SpotError(ctx context.Context, checkName string, err error) error {
var message string
if err != nil {
Expand Down