Make fairsharing stop function async #11012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing occasional lock contention with
m.coreStateLockduring shutdown. This appears to have fixed itPreviously the lock contention happened after about 2000 runs of
TestTokenStore_Revoke$. I have ran it about 75,000 times now with no issues.Failure we saw: https://app.circleci.com/pipelines/github/hashicorp/vault/15495/workflows/abd55d71-742a-41f9-aa49-4347320518e3/jobs/155458
how to exercise multiple times (using @ncabatoff
untilfailtool): go test -tags deadlock -c -o testvault ./vault; untilfail -parallel=20 ./testvault -test.run 'TestTokenStore_Revoke$'