Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn --verbose run: fix no output timeout in CI #10788

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

samsalisbury
Copy link
Contributor

CI kills the job after 10 mins with no output, verbose mode should output enough to prevent this timeout happening.

@vercel
Copy link

vercel bot commented Jan 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

vault-storybook – ./ui

🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/fswmik97w
✅ Preview: Canceled

@samsalisbury
Copy link
Contributor Author

Closing as stale.

@samsalisbury samsalisbury deleted the ui-fix-build-timeout branch April 26, 2021 15:34
@mladlow
Copy link
Contributor

mladlow commented Apr 26, 2021

@samsalisbury this was approved, what's the blocker to merging it instead of closing?

@samsalisbury
Copy link
Contributor Author

@mladlow I figured if this was still an issue then we would have heard about it? Happy to reopen & update if there's still a need for this.

@samsalisbury
Copy link
Contributor Author

OK, I just checked master and this change hasn't been made there, so I'll reopen and get this merged as it should be there really for reliability.

@samsalisbury samsalisbury restored the ui-fix-build-timeout branch April 27, 2021 11:04
@samsalisbury samsalisbury reopened this Apr 27, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 27, 2021 11:08 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 27, 2021 11:08 Inactive
@samsalisbury
Copy link
Contributor Author

Just re-did the work and force-pushed as easier than merging all these months later :)

@samsalisbury samsalisbury merged commit b46140e into master Apr 27, 2021
@samsalisbury samsalisbury deleted the ui-fix-build-timeout branch April 27, 2021 12:51
@mladlow
Copy link
Contributor

mladlow commented Apr 27, 2021

Thanks! I'm pretty sure it does still fail in this way from time to time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants