Fix setting Activity Log enable flag through the API #10594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
reviewed
Dec 17, 2020
ncabatoff
reviewed
Dec 17, 2020
ncabatoff
approved these changes
Dec 17, 2020
mgritter
approved these changes
Dec 17, 2020
Comment on lines
+169
to
+173
| func (a *ActivityLog) GetEnabled() bool { | ||
| a.fragmentLock.RLock() | ||
| defer a.fragmentLock.RUnlock() | ||
| return a.enabled | ||
| } |
There was a problem hiding this comment.
Heh... I told Bez we should just add this so we could check GetEnabled() before and after SetConfig.
There was a problem hiding this comment.
yeah so this exists in an _ent file but not OSS so I just moved it over
mgritter
pushed a commit
that referenced
this pull request
Jan 21, 2021
mgritter
pushed a commit
that referenced
this pull request
Jan 22, 2021
* core: add warning when disabling activity (#10485) * Fix setting Activity Log enable flag through the API (#10594) Co-authored-by: swayne275 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #10485
Note: I didn't add a test for
handleActivityConfigUpdateinlogical_system_test.gobecause:activity_log_test.goactivity_log_test.gotests caught this bugactivity_log_test.gotests are passing locally now