-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stacks: implement PlanTimestamp method on ExpressionScope #35367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this is a draft, so I haven't looked over it in full detail yet, but I just wanted to point out something I noticed on my first read that, if you change it in the way I proposed, would affect lots of different parts of this diff and so seemed worth raising now in case it would get harder to change after the remaining work.
Other than this I just want to make the broad note that for plantimestamp
in the modules language we remember the timestamp we generated during the plan phase so that we can return exactly the same timestamp in the apply phase. I think we either need to do similarly here (saving the plan timestamp as part of the stack plan) or we'd need to mark the result of the function as ephemeral so that Terraform doesn't expect it to remain constant between the plan and apply phases. (But then it wouldn't really be the "plan timestamp" specifically anymore.)
bbd2664
to
baa9f4e
Compare
This allows us to set the plantimestamp methods value in the stacks language
internal/stacks/stackruntime/internal/stackeval/component_instance.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one of the tests is not setting the planTimestamp
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR adds
plantimestamp
to the stacks language. It persists the timestamp in the stack plan and it uses / forces the same timestamp across all components.Fixes #
Target Release
1.10.x
Draft CHANGELOG entry
ENHANCEMENTS
plantimestamp
in the stacks language