Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and clarify error message when -plugin-dir can't be saved to working directory #35357

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

NiklasRosenstein
Copy link
Contributor

@NiklasRosenstein NiklasRosenstein commented Jun 19, 2024

Target Release

1.8.x

Draft CHANGELOG entry

  • Fixed and improved error message when -plugin-dir is used with terraform init and the values can't be saved into the workspace directory.

BUG FIXES

  • The error message would say -plugin-path when the option is actually -plugin-dir.
  • Improved said error message a bit to clarify where that value was going to be saved to.

Copy link

hashicorp-cla-app bot commented Jun 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Member

@nfagerlund nfagerlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Yeah, thanks for catching this. 👍🏼 It looks like the value provided via -plugin-dir gets stored in internal structures under the name "PluginPath" everywhere, so everyone's always primed to use use the wrong name in UI text. 😓

@nfagerlund nfagerlund merged commit 5046377 into hashicorp:main Jun 24, 2024
5 of 6 checks passed
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants