Fix IAM Policy Documentation for S3 Backend

[ajschmidt8]

This PR fixes the documentation for the S3 backend.

The current DynamoDB IAM policy states that the lock key path should be prefixed with the DynamoDB table name. This is incorrect. As indicated by the source code below, the lock key path is prefixed by the S3 bucket name, not the DynamoDB table name.

• terraform/internal/backend/remote-state/s3/client.go

  Lines 495 to 497 in a73e4e6

  	func (c *RemoteClient) lockPath() string {
  	return fmt.Sprintf("%s/%s", c.bucketName, c.path)
  	}

I've also updated the bucket's name to BucketName to match the DynamoDB table name, TableName.

[hashicorp-cla-app]

All committers have signed the CLA.

[hashicorp-cla-app]

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

_{Have you signed the CLA already but the status is still pending? Recheck it.}

[crw]

Thanks for this submission!

[dlaguerta]

Hey @ajschmidt8 , it looks like the email you signed the CLA with ([email protected]) doesn't match the commit author :

From bd9c41c Mon Sep 17 00:00:00 2001
From: AJ Schmidt [email protected]
Date: Fri, 31 May 2024 10:38:33 -0400

The CLA bot checks that the commit author matches the signer, so if you could get those two matched up, you should be ok!

[ajschmidt8]

Hey @ajschmidt8 , it looks like the email you signed the CLA with ([email protected]) doesn't match the commit author :

From bd9c41c Mon Sep 17 00:00:00 2001
From: AJ Schmidt [email protected]
Date: Fri, 31 May 2024 10:38:33 -0400

The CLA bot checks that the commit author matches the signer, so if you could get those two matched up, you should be ok!

It should be fixed in my latest commit, d7cac95.