Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Update HCL to handle type mismatches when applying defaults into v1.4 #32807

Merged

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #32775 to be assessed for backporting due to the inclusion of the label 1.4-backport.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


This PR includes a test that reproduces the crash in the linked issue, updates HCL and go-cty to fix the linked issue, and updates some tests broken as a result of the refinement features added in the latest go-cty release.

Fixes #32752

Target Release

1.4.1

Draft CHANGELOG entry

BUG FIXES

  • hcl: Fix a crash in Terraform when attempting to apply defaults into an incompatible type

@teamterraform teamterraform force-pushed the backport/liamcervante/32752/utterly-cheerful-scorpion branch from 65e8dbf to 9199f40 Compare March 9, 2023 13:30
@teamterraform teamterraform force-pushed the backport/liamcervante/32752/utterly-cheerful-scorpion branch 2 times, most recently from 758e9eb to 9199f40 Compare March 9, 2023 13:30
@liamcervante liamcervante merged commit 85e8367 into v1.4 Mar 9, 2023
@liamcervante liamcervante deleted the backport/liamcervante/32752/utterly-cheerful-scorpion branch March 9, 2023 13:59
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants