Fixed SetHardwareOptions to fetch the hardware version from QueryConfigOption instead of the default properties #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gOptions of the machine rather than the machine's properties.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When updating a "vsphere_virtual_machine" resource, the logic for
SetHardwareVersionis not fetching the version correctly. This results in the hardware version always being updated which prevents any updates of the resource until the machine is powered off.This is done by implementing the
ConfigOptionsfunction which makes aQueryConfigOptionrequest, and then refactoring the implementation ofSetHardwareVersionto compare with integers instead of having to convert the summary's attribute to a string.Acceptance tests
There were no tests for cloning, so I wasn't sure how to proceed.
References
This closes issue #1149.