Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Consul token as sensitive #73

Merged
merged 3 commits into from
Feb 27, 2019
Merged

Mark Consul token as sensitive #73

merged 3 commits into from
Feb 27, 2019

Conversation

remilapeyre
Copy link
Collaborator

Fix #50

@ghost ghost added the size/S label Nov 10, 2018
pearkes
pearkes reviewed Feb 4, 2019
View reviewed changes
Copy link
Contributor

@pearkes pearkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this needs a rebase. Also noting I believe we'd need to call this a breaking change so that means putting it in a major version.

@pearkes
Copy link
Contributor

pearkes commented Feb 21, 2019

Ah I see -- no I don't think this is going to need a breaking change. Thanks for the poke on that. 😄

@ghost ghost added size/M and removed size/S labels Feb 27, 2019
@remilapeyre remilapeyre merged commit 69cee57 into hashicorp:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearkes pearkes pearkes left review comments

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remilapeyre @pearkes