tech-debt: update SpotFleetRequest acceptance tests to use data source instance type

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14383

Notes:

• requests with m1.small instance types consistently are not fulfilled so a switch here to using the micro's seems to work and conveniently can be referenced from the data source in tests configs

Release note for CHANGELOG:

tech-debt: update SpotFleetRequest acceptance tests to use data source instance type

Output from acceptance testing:

--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (249.48s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (273.53s)

[bflad]

So much better 🚀

--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (236.38s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (283.37s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (283.45s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (304.74s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (304.76s)
--- PASS: TestAccAWSSpotFleetRequest_basic (305.41s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (305.51s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (305.58s)
--- PASS: TestAccAWSSpotFleetRequest_tags (306.27s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (306.18s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (307.43s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (307.18s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (308.23s)
--- SKIP: TestAccAWSSpotFleetRequest_WithInstanceStoreAmi (0.00s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (309.26s)
--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (347.19s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (70.35s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (125.24s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (125.05s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (273.42s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (578.10s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (580.72s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (581.56s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (581.47s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (299.80s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (300.60s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (279.90s)
--- PASS: TestAccAWSSpotFleetRequest_disappears (283.77s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (290.55s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (345.92s)
--- PASS: TestAccAWSSpotFleetRequest_zero_capacity (345.05s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (352.17s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (358.02s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (852.55s)

[ghost]

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!