Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech-debt: update data_source and resources skipped by AWSV001 check #14757

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Aug 20, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14601

Release note for CHANGELOG:

tech-debt: update data_source aws_ssm_patch_baseline operating_system validation values
tech-debt: update resource aws_appsync_graphql_api authentication_type validation values
tech-debt: update resource aws_eks_cluster enabled_cluster_log_types validation values
tech-debt: update resource aws_ssm_patch_baseline operating_system validation values

Output from acceptance testing:

--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_APIKey (61.40s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_AWSIAM (62.70s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_CognitoUserPools (64.49s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_Multiple (62.00s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_OpenIDConnect (62.57s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (113.40s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (76.24s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (77.21s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (66.55s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (68.57s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (71.03s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_ExcludeVerboseContent (127.98s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (150.00s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Name (98.67s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (110.22s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (107.75s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (127.38s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (124.43s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Schema (114.59s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Tags (97.71s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (101.01s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (98.69s)
--- PASS: TestAccAWSAppsyncGraphqlApi_XrayEnabled (77.03s)
--- PASS: TestAccAWSAppsyncGraphqlApi_basic (60.99s)
--- PASS: TestAccAWSAppsyncGraphqlApi_disappears (45.10s)
--- PASS: TestAccAWSEksClusterAuthDataSource_basic (50.81s)
--- PASS: TestAccAWSEksClusterDataSource_basic (795.12s)
--- PASS: TestAccAWSEksCluster_EncryptionConfig (765.20s)
--- PASS: TestAccAWSEksCluster_Logging (968.25s)
--- PASS: TestAccAWSEksCluster_Tags (848.09s)
--- PASS: TestAccAWSEksCluster_Version (1467.21s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPrivateAccess (2396.64s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPublicAccess (1721.13s)
--- PASS: TestAccAWSEksCluster_VpcConfig_PublicAccessCidrs (1311.03s)
--- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (747.26s)
--- PASS: TestAccAWSEksCluster_basic (827.58s)
--- PASS: TestAccAWSSSMPatchBaseline_OperatingSystem (34.19s)
--- PASS: TestAccAWSSSMPatchBaseline_basic (38.55s)
--- PASS: TestAccAWSSSMPatchBaseline_disappears (20.50s)
--- PASS: TestAccAWSSSMPatchBaseline_tags (46.51s)
--- PASS: TestAccAWSSsmPatchBaselineDataSource_existingBaseline (51.48s)
--- PASS: TestAccAWSSsmPatchBaselineDataSource_newBaseline (67.78s)

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Aug 20, 2020
@anGie44 anGie44 changed the title tech-debt: update data_source resources skipped by AWSV001 check tech-debt: update data_source and resources skipped by AWSV001 check Aug 20, 2020
@ghost ghost added service/appsync Issues and PRs that pertain to the appsync service. service/eks Issues and PRs that pertain to the eks service. service/ssm Issues and PRs that pertain to the ssm service. labels Aug 20, 2020
@anGie44 anGie44 added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Aug 20, 2020
@anGie44 anGie44 marked this pull request as ready for review August 20, 2020 19:34
@anGie44 anGie44 requested a review from a team August 20, 2020 19:34
@bflad bflad modified the milestone: v3.3.0 Aug 20, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

Output from acceptance testing:

--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_APIKey (66.29s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_AWSIAM (67.25s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_CognitoUserPools (65.21s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_Multiple (64.74s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_OpenIDConnect (63.52s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (112.65s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (67.97s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (63.75s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (70.74s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (68.32s)
--- PASS: TestAccAWSAppsyncGraphqlApi_basic (69.96s)
--- PASS: TestAccAWSAppsyncGraphqlApi_disappears (57.80s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (73.29s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_ExcludeVerboseContent (123.84s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (154.48s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Name (112.87s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (119.77s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (123.23s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (107.40s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (108.88s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Schema (136.02s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Tags (95.08s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (95.70s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (95.75s)
--- PASS: TestAccAWSAppsyncGraphqlApi_XrayEnabled (84.11s)

--- PASS: TestAccAWSEksCluster_basic (837.15s)
--- PASS: TestAccAWSEksCluster_EncryptionConfig (695.66s)
--- PASS: TestAccAWSEksCluster_Logging (938.05s)
--- PASS: TestAccAWSEksCluster_Tags (891.49s)
--- PASS: TestAccAWSEksCluster_Version (1467.33s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPrivateAccess (2457.19s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPublicAccess (1752.10s)
--- PASS: TestAccAWSEksCluster_VpcConfig_PublicAccessCidrs (1061.15s)
--- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (1016.47s)

--- PASS: TestAccAWSSSMPatchBaseline_basic (38.01s)
--- PASS: TestAccAWSSSMPatchBaseline_disappears (21.40s)
--- PASS: TestAccAWSSSMPatchBaseline_OperatingSystem (35.25s)
--- PASS: TestAccAWSSSMPatchBaseline_tags (47.27s)

--- PASS: TestAccAWSSsmPatchBaselineDataSource_existingBaseline (57.69s)
--- PASS: TestAccAWSSsmPatchBaselineDataSource_newBaseline (57.31s)

@anGie44 anGie44 added this to the v3.3.0 milestone Aug 20, 2020
@anGie44 anGie44 merged commit bb114f7 into master Aug 20, 2020
@anGie44 anGie44 deleted the td-validation-string-vars branch August 20, 2020 21:01
@ghost
Copy link

ghost commented Aug 20, 2020

This has been released in version 3.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/appsync Issues and PRs that pertain to the appsync service. service/eks Issues and PRs that pertain to the eks service. service/ssm Issues and PRs that pertain to the ssm service. size/S Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants