Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/fwschemadata: Replace fwserver duplicate logic, add data description #464

Merged
merged 3 commits into from
Aug 30, 2022

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 29, 2022

Reference: #365
Reference: #366

This change represents another evolutionary step to move away from tfsdk.Config, tfsdk.Plan, and tfsdk.State types directly, where the temporarily duplicated logic in internal/fwserver which worked directly with those types is replaced with the shared data implementation.

…cription

Reference: #365
Reference: #366

This change represents another evolutionary step to move away from `tfsdk.Config`, `tfsdk.Plan`, and `tfsdk.State` types directly, where the temporarily duplicated logic in `internal/fwserver` which worked directly with those types is replaced with the shared data implementation.
@bflad bflad added the tech-debt Issues tracking technical debt that we're carrying. label Aug 29, 2022
@bflad bflad added this to the v0.12.0 milestone Aug 29, 2022
@bflad bflad requested a review from a team as a code owner August 29, 2022 20:02
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit 5810578 into main Aug 30, 2022
@bflad bflad deleted the bflad/fwserver-migrate-to-fwschemadata-handlers branch August 30, 2022 14:40
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tech-debt Issues tracking technical debt that we're carrying.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants