Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/fwschemadata: Migrate tfsdk GetAttribute and getAttributeValue logic #453

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 14, 2022

Reference: #366

This change continues the migration of tfsdk.Config/tfsdk.Plan/tfsdk.State type logic into the internal/fwschemadata package Data type, so the implementation is shared and to potentially introduce other implementations.

…ue logic

Reference: #366

This change continues the migration of `tfsdk.Config`/`tfsdk.Plan`/`tfsdk.State` type logic into the `internal/fwschemadata` package `Data` type, so the implementation is shared and to potentially introduce other implementations.
@bflad bflad added the tech-debt Issues tracking technical debt that we're carrying. label Aug 14, 2022
@bflad bflad added this to the v0.12.0 milestone Aug 14, 2022
@bflad bflad requested a review from a team as a code owner August 14, 2022 15:12
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad modified the milestones: v0.12.0, v0.11.1 Aug 15, 2022
@bflad bflad merged commit 655bd5d into main Aug 15, 2022
@bflad bflad deleted the bflad/fwschemadata-GetAttribute branch August 15, 2022 08:03
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tech-debt Issues tracking technical debt that we're carrying.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants