Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Terraform 0.12.25, add TF_VERSION environment variable #48

Merged
merged 4 commits into from
May 14, 2020
Merged

Update to Terraform 0.12.25, add TF_VERSION environment variable #48

merged 4 commits into from
May 14, 2020

Conversation

joatmon08
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #47

Release note for CHANGELOG:

Update to Terraform 0.12.25 and add TF_VERSION environment variable (#47)

When the operator creates a workspace in TFC/E, it defaults the version of Terraform to what is compiled with the operator. Otherwise, override the Terraform version for the workspace using the TF_VERSION environment variable.

@joatmon08 joatmon08 changed the title Tf 0.12.25 Update to Terraform 0.12.25, add TF_VERSION environment variable May 14, 2020
@joatmon08 joatmon08 requested a review from a team May 14, 2020 14:55
aareet
aareet approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@aareet aareet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Should we add a note about setting TF_VERSION to the README?

@joatmon08
Copy link
Contributor Author

@aareet Updated the docs under hashicorp/terraform-helm/pull/11!

dak1n1
dak1n1 approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@dak1n1 dak1n1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joatmon08 joatmon08 merged commit f7268f5 into master May 14, 2020
@joatmon08 joatmon08 deleted the tf-0.12.25 branch May 14, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aareet aareet aareet approved these changes

@dak1n1 dak1n1 dak1n1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin Terraform Version in Workspace
3 participants
@joatmon08 @aareet @dak1n1