Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for variable value from secretKeyRef #137

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

jtyr
Copy link
Contributor

@jtyr jtyr commented Apr 19, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This PR is adding support for fromValue.secretKeyRef for the Workspace resource. This allows to read a variable value from the specified secret key. This PR needs to be rebase after PR #133 is merged as it shares the GetSecretData method.

Usage in the Workspace resource:

...
spec:
  variables:
    - key: sensitive
      sensitive: true
      # This is the new feature
      valueFrom:
        secretKeyRef:
          name: test
          key: foo

Release note for CHANGELOG:

Added support for secretKeyRef for variables

Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jtyr,

I have left one comment, could you please look at it?

Thank you.

workspacehelper/k8s_secret.go Outdated Show resolved Hide resolved
@arybolovlev arybolovlev merged commit 0d17251 into hashicorp:master Jun 28, 2022
@jtyr jtyr deleted the jtyr-fromsec branch August 29, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants