cleanup: replace TypeToPtr helper methods with pointer.Of

[pkazmierczak]

Bumping compile time requirement to go 1.18 allows us to simplify our pointer helper methods.

[tgross]

LGTM. 👍

This forces API consumers to bump to go1.18 but seeing as how go1.17 is out of support I don't think that's actually a problem? We should almost certainly backport this to all supported versions, because (a) it'll make for a lot of merge conflicts on backport if we don't and (b) we should get the minimum toolchain bump into those older supported versions as well.

[shoenig]

LGTM! I was planning on doing this slowly over 2-3 years, but all at once works too 😅

that checks action does look suspicious though

==> Linting hclog statements...
hclogvet: Unexpected package creation during export data loading
make: *** [GNUmakefile:162: check] Error 1
Error: Process completed with exit code 2.

[pkazmierczak]

that checks action does look suspicious though

==> Linting hclog statements...
hclogvet: Unexpected package creation during export data loading
make: *** [GNUmakefile:162: check] Error 1
Error: Process completed with exit code 2.

Yeah... so it's because hclogvet uses an outdated go tools version. They recently fixed this issue, I guess I'm gonna have to open a PR against go-hclog...

I tested on my laptop with hclogvet built against latest go-tools and it worked fine.

[shoenig]

@pkazmierczak yeah go ahead and make the PR to update go-hclog; I had to do something similar during the 1.18 upgrade too

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.