Add encoding API functions #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The std encoding format is Unmarshal([]byte, interface{}) error.
This naturally lends itself well to being passed readfile or exhausted
reader/buffer.
| @@ -21,6 +21,17 @@ var ( | |||
| nodeType reflect.Type = findNodeType() | |||
| ) | |||
|
|
|||
| // Unmarshal accepts a byte slice as input and writes the | |||
| // data to the value pointed to by v. | |||
| func Unmarshal(bs []byte, v interface{}) error { | |||
There was a problem hiding this comment.
Is there an argument here for reordering the parameters as in Decode below? Practically it is Decode which doesn't honour the convention but that is in pretty heavy use now.
There was a problem hiding this comment.
Go has some odd conventions where Unmarshal is data first, but things like io.Copy are destination first. :-\
|
LGTM with one minor note! |
apparentlymart
pushed a commit
that referenced
this pull request
Sep 9, 2019
…d. (#97) Previously, hclsyntax MissingItemRange() function returned a zero-length range anchored at the end of the block in question. This commit changes that to the beginning of the block. In practice, the end of a block is generally just a "}" and not very useful in error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The std encoding format is Unmarshal([]byte, interface{}) error.
This naturally lends itself well to being passed readfile or exhausted
reader/buffer.
This is just a rebase of 92 with authorship maintained