Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport unused key tracking from main to the Vault fork branch #466

Merged
merged 5 commits into from
May 4, 2021

Conversation

sgmiller
Copy link

... and add file position tracking.

@sgmiller sgmiller requested a review from HridoyRoy April 30, 2021 19:27
@sgmiller sgmiller changed the title Backport unused key tracking from main to the Vault branch Backport unused key tracking from main to the Vault fork branch May 3, 2021
Copy link

@HridoyRoy HridoyRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -1,3 +1,5 @@
module github.com/hashicorp/hcl

go 1.15

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question, I noticed that go.mod's go version was upgraded to go 1.15, which I believe means the minimum version required to use the hcl library is 1.15 right? Are all the plugins using this hcl library on version 1.15?

@sgmiller sgmiller merged commit 4ecc8ee into v1.0.1-vault May 4, 2021
@sgmiller sgmiller deleted the unused-backport branch May 4, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants