hclsyntax: Fix panic for marked template loops #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pselle
approved these changes
Dec 18, 2020
| Variables: map[string]cty.Value{ | ||
| "secrets": cty.ListVal([]cty.Value{ | ||
| cty.StringVal("foo"), | ||
| cty.StringVal("bar"), |
There was a problem hiding this comment.
Question about test coverage addition where a member of the collection is marked, but the collection itself is not initially marked.
There was a problem hiding this comment.
Excellent catch! I added a test, found another panic, and fixed the panic. Thank you!
If individual template expressions in a loop have marks, merge those marks into the final result when joining.
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this downstream Terraform bug. I couldn't find any other instances of calling
ElementIteratoron a possibly-marked collection (except in splat expressions, which is fixed by #436).