hclsyntax: address multiple issues with sequences (...) #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously functions such as concat() would result in a panic if there was a null element and a sequence, as in the included test. This PR adds a check if the error index is outside of the range of arguments and crafts an error that references the entire function instead of the null argument.
|
hashicorp/terraform#24910 is the reference for the second commit, which addresses the following error with Previous error (as shown by the test added in this comment): New result: no errors, returns |
jbardin
reviewed
Jun 3, 2020
| @@ -260,6 +260,8 @@ func (e *FunctionCallExpr) Value(ctx *hcl.EvalContext) (cty.Value, hcl.Diagnosti | |||
| } | |||
|
|
|||
| switch { | |||
| case expandVal.Type().Equals(cty.DynamicPseudoType): | |||
There was a problem hiding this comment.
If passing null as the first argument isn't valid, we should have the same null check here as below. Otherwise we have a known value turning into an unknown value.
jbardin
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: I ended up tackling two adjacent bugs at once.
Previously functions such as
concat()would result in a panic if therewas a null element and a sequence, as in the included test. This PR adds
a check if the error index is outside of the range of arguments and
crafts an error that references the entire function instead of the null
argument.
Tested locally to confirm that this fixes a reported terraform panic:
