Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds another job to run the go tests on a Windows executor, which will let us get rid of the appveyor dependency. To run tests with different versions of go, add the version(s) to the array's on lines 170 and 175.
The linux and win tests run at the same time, but the Windows job does take a bit longer to finish due to the nature of the executor + some required setup steps. The workflow takes around ~1:23 to complete. The longest step (w/out caching) is installing go, which we have to do because the Windows executor only has go 1.12 installed. This job has gomod + coverage persistence + golang caching enabled, so it's a bit quicker.
Besides removing the appveyor file, I also removed the travis config file in this PR, as the circle config seems to cover all tests for branch pushes/pr's/merges.
Let me know if you see anything wonky, and thanks for your review!