Decode string booleans #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apparentlymart
approved these changes
Jun 10, 2019
There was a problem hiding this comment.
The fact that there was already a case for token.NUMBER here suggests that the original intent was for the decoder to do automatic conversions from other primitive types to string, so this seems reasonable to me.
The results here are also consistent with the automatic conversions from numbers and bools to string in HCL 2, so the same input would produce an equivalent result in HCL 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're decoding into a string value, convert the other literal types (FLOAT and BOOL) to strings as well. Previously, decoding would fail on an unexpected literal type.