Modify new bytes.ContainsRune to backward compatible bytes.IndexRune #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general we only support the latest Go version and ask you use vendoring to support prior versions. But due to the simplicity of this change I'll take it. :) |
|
That's great to hear @mitchellh. Thank you for your understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this change is so that the code is valid in Go < 1.7. I am using hcl/printer in spf13/viper#287. It requires tests in Go < 1.7, so this prevents that from passage. I did a work around using build constraints, but it is pretty ugly. It would be much better without that workaround being required and there will be no impact on hcl.