missing fields when decoding JSON #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A JSON object with a single entry containing a single object fails to decode.
8957d79
to
6502ffe
Compare
|
This will fix #153 |
Remove a level of nesting and separate the passing and failing cases.
A single json object with nested objects is flattened by the json parser to a list of objects sharing the parent key. If we're decoding into struct this was likely a mistake, and we need to re-expand the ast.
405c6de
to
d3228f1
Compare
|
All tests green! 🍏 |
685618c
to
4c160c8
Compare
|
Looks really great! :D |
Make TestDecode_flattenedJSON table driven to add more test cases as reproduced in terraform.
Now that we know only individual items in a slice need to be expanded, we can simplify the code flow to expand the ast in place while decoding.
4c160c8
to
0bcadf0
Compare
|
rebased in some spelling/comment fixes. |
jbardin
added a commit
that referenced
this pull request
Oct 14, 2016
missing fields when decoding JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A single JSON object with a single key and value of a another object fails to decode.