Add test for stdout scanner race with runner.Wait() #300
+84
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test-case for #299 that reliably fails before the patch, and reliably passes after it.
I ran
go test -count=100 -run ^TestClient_noStdoutScannerRace$ github.com/hashicorp/go-plugin
on commits 586d14f (but with this test added) and 9b34846, and got 100/100 failures and 0/100 failures respectively.