Backport of build: cross compile darwin builds into release/1.19.x #21373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/dans/NET-9235/cross-compile-darwin/separately-main-seasnail
branch
from
9b37cbd
to
4655112
Compare
github-team-consul-core-pr-approver
approved these changes
Jun 26, 2024
github-actions
bot
added
type/ci
DanStough
deleted the
backport/dans/NET-9235/cross-compile-darwin/separately-main-seasnail
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21326 to be assessed for backporting due to the inclusion of the label backport/1.19.
The below text is copied from the body of the original PR.
Description
For cost reasons, we can cross-compile macos binaries on linux. Historically we didn't do this because of a problem with Go that has since been resolved: #3267.
This step removes the verification of Darwin binaries. I believe this is acceptable since the vast majority of users and on Linux and Windows. Developers will naturally test the Darwin build during the development cycle.
Overview of commits