Create documentation for Argo Rollouts Plugin. #20680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
added
the
type/docs
thisisnotashwin
force-pushed
the
ashwin-michael/add-docs-for-rollouts-plugin
branch
2 times, most recently
from
0cf4d1a
to
2d4056b
Compare
wilkermichael
added
the
pr/no-changelog
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
thisisnotashwin
force-pushed
the
ashwin-michael/add-docs-for-rollouts-plugin
branch
from
2d4056b
to
a76a917
Compare
thisisnotashwin
added
backport/1.15
thisisnotashwin
force-pushed
the
ashwin-michael/add-docs-for-rollouts-plugin
branch
2 times, most recently
from
f77ea18
to
4f48ba9
Compare
david-yu
reviewed
Feb 21, 2024
david-yu
reviewed
Feb 21, 2024
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
david-yu
approved these changes
Feb 21, 2024
wilkermichael
approved these changes
Feb 21, 2024
boruszak
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
I left suggestions to match the documentation style guide and page layouts. Approving so that you're not blocked, but there's a number of big structural changes, so please don't hesitate to reach out if you need additional review on this PR!
Approving on behalf of consul-docs
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: David Yu <[email protected]>
Co-authored-by: Jeff Boruszak <[email protected]>
thisisnotashwin
force-pushed
the
ashwin-michael/add-docs-for-rollouts-plugin
branch
from
fec02a6
to
5a2105c
Compare
boruszak
approved these changes
Feb 21, 2024
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeff Boruszak <[email protected]>
wilkermichael
approved these changes
Mar 6, 2024
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx
Outdated
Show resolved
Hide resolved
…ts-configuration.mdx
…ts-configuration.mdx
david-yu
removed
the
backport/1.15
|
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
github-actions
bot
added
the
meta/stale
github-actions
bot
removed
the
meta/stale
|
@blake Should we merge these docs for the upcoming release? Argo rollouts were listed on your recent roadmap |
boruszak
added
backport/1.19
|
Update: These docs are complete, but we should not publish until Argo Rollouts v1.7 is released. Currently they're only in the release candidate: https://github.com/argoproj/argo-rollouts/releases |
4 tasks
4 tasks
danielehc
pushed a commit
that referenced
this pull request
Jun 25, 2024
* Create documentation for Argo Rollouts Plugin. * Create documentation for Argo Rollouts Plugin. * Apply suggestions from code review Co-authored-by: David Yu <[email protected]> * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Update docs based on feedback * Apply suggestions from code review Co-authored-by: Jeff Boruszak <[email protected]> * Update website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx * Update website/content/docs/k8s/deployment-configurations/argo-rollouts-configuration.mdx --------- Co-authored-by: David Yu <[email protected]> Co-authored-by: Jeff Boruszak <[email protected]> Co-authored-by: Michael Wilkerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VERCEL LINK: https://consul-31z9s3g9y-hashicorp.vercel.app/consul/docs/k8s/deployment-configurations/argo-rollouts-configuration
Testing & Reproduction steps
Links
PR Checklist