Updated release procedure #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,7 +107,6 @@ module.exports = (grunt) -> | |||
| "description": pkg.description | |||
| "version": version() | |||
| "licenses": pkg.licenses | |||
| "download": version_url() | |||
There was a problem hiding this comment.
Wouldn't we want to just hardcode in the releases page for download? We can just put it in the package.json under jqueryJSON
There was a problem hiding this comment.
See, I thought I did that in the chosen.jquery.json file. Oops.
|
It all looks good to me. |
|
Looks good, and I guess pointing to a prototype example is not of that much use, as the functionality is the same. So 👍 for that also |
pfiller
added a commit
that referenced
this pull request
Jul 10, 2013
Updated release procedure to remove S3 #1323
pfiller
added a commit
that referenced
this pull request
Jul 10, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kenearley @stof @koenpunt
Our S3 experiment is not going to last long. @kenearley has already pointed out some possible awkwardness with it and GitHub's releases pretty much makes some of the stuff we're doing unnecessary.
If this lands, the new process for updating a release would look like this:
package.jsongrunt prep_releasepackage.jsonandchosen.jquery.jsonfile changes with a version summary (see 3a43166 for an example).This PR also includes some changes to the documentation that will reduce the amount of times we need to push to
gh_pages. Eventually, I'd like to add the version number back and include a direct link to the zip file on the release ... but GitHub doesn't currently offer a file naming convention that backs us up there.