Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message upon each retry failure #973

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brandboat
Copy link

@brandboat brandboat commented Mar 18, 2024

Summary

this is part of harvester/harvester#5288, after harvester/harvester#5386 merged to master, error message updated upon each retry failure. Before this pr, error message pops up only when upgrad CR imageReady is False.

Occurred changes and/or fixed issues

related to harvester/harvester#5288

Technical notes summary

N/A

Areas or cases that should be tested

Harvester upgrade

Areas which could experience regressions

N/A

Screenshot/Video

Test upgrade

Screenshot from 2024-03-18 17-14-14

Screencast.from.2024-03-18.17-17-20.webm

Test Image
Screenshot from 2024-03-20 14-08-31

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants