Vagrant kick over to Dockerfile #935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 23, 2015 08:41
Adding boiler plate Vagrant config which will kick over to the Dockerfile. Will only break if: a) Vagrant docker provider is not present; or b) You dont have docker installed c) Your dockerfile/build is broken
|
withdrawing for port forward fix |
bot2-harness
pushed a commit
that referenced
this pull request
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Guys,
I saw the discussion around issue 915 and although removing
Vagrant makes sense if no-one is looking after it I thought
I would suggest an alternative.
The associated change will allow vagrant based toolsets to
continue to run drone, only with some extra dependencies:
The change itself is boiler plate. grabbed directly from the
Vagrant docker provider documentation:
http:https://docs.vagrantup.com/v2/docker/basics.html
Obviously it's up to you, but this change will potentially
break less ppl